Andreas Svanberg ansv7779
  • Joined on 2021-07-26
ansv7779 approved DMC/studentportalen#62 2026-01-16 13:39:03 +01:00
Start time grid
ansv7779 suggested changes for DMC/studentportalen#62 2026-01-14 10:39:04 +01:00
Start time grid

Everything is still typed as string and continuously parsed to temporal types (that get immediately thrown away). The useGroupRoomBooking should convert the stringly typed JSON object from the API to well-typed data for use in the rest of the system.

ansv7779 created pull request DMC/oauth2-authorization-server#12 2026-01-13 14:53:39 +01:00
Speed up client and authorization lookup with database indexes
ansv7779 created branch slow-login in DMC/oauth2-authorization-server 2026-01-13 14:46:16 +01:00
ansv7779 pushed to slow-login at DMC/oauth2-authorization-server 2026-01-13 14:46:16 +01:00
6c2f90774d Speed up client and authorization lookup with database indexes
ansv7779 approved DMC/studentportalen#65 2026-01-13 10:30:03 +01:00
Add Checkstyle and Prettier to BFF

One minor issue that would have been good to address is the need to run npm install in bff/ before you can run any Maven command. Running npm install (and maybe even installing Node and npm) via Maven before attempting to run Prettier would have been nice.

ansv7779 commented on pull request DMC/studentportalen#62 2026-01-12 12:07:16 +01:00
Start time grid

This needs some documentation what it is. Inline and modal are to me opposing concepts. What actually is it? When would I use it compared to a modal dialog and how is it different from just a <div>?

ansv7779 commented on pull request DMC/studentportalen#62 2026-01-12 12:07:16 +01:00
Start time grid

Everything else is a SVG icon, why not this too? Using a CSS border trick feels like a relic from the past.

ansv7779 suggested changes for DMC/studentportalen#62 2026-01-12 12:07:16 +01:00
Start time grid

Use the new Temporal API with one of the available polyfills (temporal-polifyll being the most popular). Having everything as a string and using regular expressions or string splitting is not good.

ansv7779 approved DMC/studentportalen#64 2026-01-12 11:40:55 +01:00
Refactor BFF Package Structure
ansv7779 approved DMC/studentportalen#31 2025-12-17 21:15:43 +01:00
List components
ansv7779 commented on pull request DMC/studentportalen#31 2025-12-17 11:33:18 +01:00
List components

I think this component would have been better split into two, a single select and a multiple select version. If I use it with multiple={false} I would not want my onChange callback to be called with an array of choices.

ansv7779 commented on pull request DMC/studentportalen#31 2025-12-17 11:33:18 +01:00
List components

This is limiting. Often times you want to select some more complex object as you do in your examples in ComponentLibrary. Forcing all users of the component to do their own lookup when it should be handled by the Combobox/this component.

ansv7779 approved DMC/studentportalen#31 2025-12-17 11:33:18 +01:00
List components
ansv7779 approved DMC/studentportalen#30 2025-12-16 16:12:50 +01:00
Text input component
ansv7779 commented on pull request DMC/studentportalen#30 2025-12-16 14:02:26 +01:00
Text input component

Shouldn't icons inherit their size from their context? Like if I add an icon to a small button or a large heading I would assume it would scale to that context rather than having its own independent size.

ansv7779 commented on pull request DMC/studentportalen#30 2025-12-16 14:02:26 +01:00
Text input component

Should label really be optional? Will that not lead to accessibility issues?

ansv7779 commented on pull request DMC/studentportalen#30 2025-12-16 14:02:26 +01:00
Text input component

Icon with capital I?

ansv7779 commented on pull request DMC/studentportalen#30 2025-12-16 14:02:26 +01:00
Text input component

Without having seen an example of a full form with validation it's hard to tell if this is the path forward. We can probably leave it for now.

ansv7779 approved DMC/studentportalen#29 2025-12-12 10:31:29 +01:00
button-component