Andreas Svanberg ansv7779
0 Followers · 0 Following
  • Joined on 2021-07-26
Repositories
3
 Projects Packages Public Activity Starred Repositories
ansv7779 commented on pull request DMC/studentportalen#5 2025-04-09 16:45:35 +02:00
Add i18n support

Running npm run build produces no output.

ansv7779 commented on pull request DMC/studentportalen#5 2025-04-09 13:08:32 +02:00
Add i18n support
ansv7779 commented on pull request DMC/studentportalen#5 2025-04-09 12:59:12 +02:00
Add i18n support

I put the i18n initialization stuff in main.tsx because we need to have it in place before we have a profile and display the splash screen, I thought it felt like a natural flow of things,…

ansv7779 commented on pull request DMC/studentportalen#5 2025-04-09 12:21:46 +02:00
Add i18n support

Do we need this since the generated .ts files have /*eslint-disable*/ at the start?

ansv7779 commented on pull request DMC/studentportalen#5 2025-04-09 12:21:46 +02:00
Add i18n support

Need instructions in the readme what these commands do and what the expected workflow is when adding/translating new content.

ansv7779 commented on pull request DMC/studentportalen#5 2025-04-09 12:21:46 +02:00
Add i18n support

Should maybe iterate over navigator.languages instead to find the most preferred locale? If a user sends "Accept-Language: de-DE, en-US, sv-SE" they will get Swedish instead of English since German isn't available.

ansv7779 suggested changes for DMC/studentportalen#5 2025-04-09 12:21:46 +02:00
Add i18n support

Overall it looks good, some minor questions in individual comments.

ansv7779 pushed to branch-pr-deployment at DMC/studentportalen 2025-04-08 23:21:56 +02:00
183407fed0 Deploy PRs to a test server
ansv7779 pushed to main at DMC/oauth2-authorization-server 2025-04-08 22:50:08 +02:00
14f7ca66cb Utilize X-Forwarded-* headers in embedded Docker container
ansv7779 pushed to branch-pr-deployment at DMC/studentportalen 2025-04-08 17:03:31 +02:00
e7801276a8 First attempt at branch deployment
ansv7779 pushed to branch-pr-deployment at DMC/studentportalen 2025-04-08 16:50:12 +02:00
270338ac50 First attempt at branch deployment
ansv7779 pushed to x-forwarded-headers at DMC/oauth2-authorization-server 2025-04-08 16:49:49 +02:00
709dc23250 Take into account X-Forwarded-* headers in embedded mode.
1a2a84f674 Immediately show authorization request errors before showing the custom authorization form
857d59d391 Better error handling, especially during developer authorization
c421125eb4 Fix Shibboleth/Tomcat providing a principal with a blank name in the unauthenticated case
71862afb55 Introduce a training run in the Docker build to speed it up
Compare 5 commits »
ansv7779 created branch x-forwarded-headers in DMC/oauth2-authorization-server 2025-04-08 16:48:54 +02:00
ansv7779 pushed to x-forwarded-headers at DMC/oauth2-authorization-server 2025-04-08 16:48:54 +02:00
1d81e3887a Take into account X-Forwarded-* headers in embedded mode.
ansv7779 pushed to branch-pr-deployment at DMC/studentportalen 2025-04-08 16:39:06 +02:00
799c445fb4 First attempt at branch deployment
ansv7779 pushed to branch-pr-deployment at DMC/studentportalen 2025-04-08 16:31:33 +02:00
641b258e34 First attempt at branch deployment
ansv7779 pushed to branch-pr-deployment at DMC/studentportalen 2025-04-08 16:25:30 +02:00
64020a14d4 First attempt at branch deployment
ansv7779 pushed to branch-pr-deployment at DMC/studentportalen 2025-04-08 16:20:36 +02:00
cb65ae3c9f First attempt at branch deployment
ansv7779 pushed to branch-pr-deployment at DMC/studentportalen 2025-04-08 16:14:35 +02:00
afe1810570 First attempt at branch deployment
ansv7779 pushed to branch-pr-deployment at DMC/studentportalen 2025-04-08 16:12:44 +02:00
cc0af364da First attempt at branch deployment