DMC/scipro
7
0
Fork 0
Code Issues 27 Pull Requests 4 Actions Projects 1 Wiki Activity

Bug resubmissions of final thesis shows old date #113

Merged
ansv7779 merged 1 commits from bug-old-date-final-thesis into develop 2025-02-19 09:37:34 +01:00
Conversation 2 Commits 1 Files Changed 1 +1
niat8586 commented 2025-02-18 09:22:46 +01:00
Owner
Copy Link

Fixes #79

How to test

This will not be possible to test in with the provided branch link due to integrations with daisy API.

Previously if an author resubmitted their final thesis to the supervisor fora re-submission to the examiner the date of submission was the first submitted final thesis. And the status text only showed "Waiting for grading". This caused a lot of confusion for the authors when the dates and status of the final thesis was divergent from their perceived view of dates and changes.

Fixes #79 ### How to test This will not be possible to test in with the provided branch link due to integrations with daisy API. Previously if an author resubmitted their final thesis to the supervisor fora re-submission to the examiner the date of submission was the first submitted final thesis. And the status text only showed "Waiting for grading". This caused a lot of confusion for the authors when the dates and status of the final thesis was divergent from their perceived view of dates and changes.
gitea-actions commented 2025-02-18 09:26:11 +01:00
First-time contributor
Copy Link

Deployed to https://scipro-bug-old-date-final-thesis.branch.dsv.su.se

Deployed to https://scipro-bug-old-date-final-thesis.branch.dsv.su.se
niat8586 added 1 commit 2025-02-19 08:46:09 +01:00
Resubmission of final thesis should show correct date
All checks were successful
Deploy to branch.dsv.su.se / deploy (pull_request) Successful in 6m49s
Details
Build and test / build-and-test (push) Successful in 16m27s
Details
Remove branch deployment from branch.dsv.su.se / cleanup (pull_request) Successful in 38m44s
Details
5820a87fd6 
If an examiner rejected a final thesis and the author resubmitted a thesis
to his supervisor so it can be sent to the examiner for a new round. When
that happened the feedback to the author was wrong, after a resubmission was
made and sent to the examiner the first thesis date 'Submitted to examiner' was
shown. This caused a lot of confusion. This happened because after the rejection
the date for when it was submitted to the examiner was not reset.

Now the date is reset and the feedback loop regarding dates is the same as when they first
send in their final thesis. In other words, when they resubmit their thesis they will not
see a 'Submitted to examiner' date until the supervisor actually resends the thesis to the
examiner. Then the date feedback will show up for the author with the correct date it was sent
to the examiner.
niat8586 changed title from WIP: Bug resubmissions of final thesis shows old date to Bug resubmissions of final thesis shows old date 2025-02-19 08:49:20 +01:00
ansv7779 approved these changes 2025-02-19 09:36:47 +01:00
ansv7779 merged commit 9b26843570 into develop 2025-02-19 09:37:34 +01:00
ansv7779 deleted branch bug-old-date-final-thesis 2025-02-19 09:37:34 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
ansv7779
Labels
Clear labels
bug
Something is not working
discussion
duplicate
This issue or pull request already exists
enhancement
New feature
frozen
The issue is not solved, but it will be investigated in the future it the issue arises again
help wanted
Need some help
invalid
Something is wrong
new
To be discussed at the next meeting
po
approved
po
changes
PO has requested changes
po
needed
question
More information is needed
size
1
size
2
size
3
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DMC/scipro#113
No description provided.
Delete Branch "bug-old-date-final-thesis"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?