Stefan Nenzén stne3960
  • Joined on 2023-01-12
stne3960 closed issue DMC/studentportalen#21 2025-12-18 12:42:12 +01:00
Component / Participant picker
stne3960 closed issue DMC/studentportalen#22 2025-12-18 12:42:12 +01:00
Component / List card
stne3960 pushed to main at DMC/studentportalen 2025-12-18 12:41:15 +01:00
e64d9bc511 List components (#31)
stne3960 deleted branch list_item from DMC/studentportalen 2025-12-18 12:41:15 +01:00
stne3960 merged pull request DMC/studentportalen#31 2025-12-18 12:41:13 +01:00
List components
stne3960 pushed to list_item at DMC/studentportalen 2025-12-17 14:41:15 +01:00
bbe1012b80 Use generics for selection
stne3960 pushed to list_item at DMC/studentportalen 2025-12-17 11:02:03 +01:00
97984a21b9 Update package
stne3960 pushed to list_item at DMC/studentportalen 2025-12-17 11:00:40 +01:00
91a002cc9a Update ComponentLibrary
99a6d9bde5 Refactor ParticipantPicker
14ab479b26 Refactor Combobox
8ccf57eb16 Refactor SearchResultList
1e0093c887 Refactor ListCard
Compare 11 commits »
stne3960 pushed to main at DMC/studentportalen 2025-12-16 17:59:35 +01:00
e359e1cf06 Text input component (#30)
stne3960 deleted branch text_input from DMC/studentportalen 2025-12-16 17:59:35 +01:00
stne3960 merged pull request DMC/studentportalen#30 2025-12-16 17:59:33 +01:00
Text input component
stne3960 pushed to text_input at DMC/studentportalen 2025-12-16 15:47:41 +01:00
a4657951fb Force label, use aria-label when hidden
stne3960 commented on pull request DMC/studentportalen#30 2025-12-16 14:58:17 +01:00
Text input component

In practical implementation, probably not, that was how the component was designed in the specification.

stne3960 commented on pull request DMC/studentportalen#30 2025-12-16 14:57:29 +01:00
Text input component

I’d keep the error prop for now. Native validation works for some cases but gets awkward once you have server errors or custom validation. An explicit error state keeps the component predictable.

stne3960 commented on pull request DMC/studentportalen#30 2025-12-16 14:56:20 +01:00
Text input component

Yes, it's a component

stne3960 commented on pull request DMC/studentportalen#30 2025-12-16 14:56:04 +01:00
Text input component

For certain cases, yes, it probably should. I've added inherit as a default. However, we need to be able to override it like in the TextInput component. Here, the icon is in a dedicated container…

stne3960 pushed to text_input at DMC/studentportalen 2025-12-16 14:52:32 +01:00
d6a65eee0b Make icons inherit size
stne3960 pushed to text_input at DMC/studentportalen 2025-12-16 13:17:33 +01:00
cb510e4ce1 Update Component library
a9d9f6c722 Add icon component
a15b8b500e Use same patterns as button, prettier
Compare 3 commits »
stne3960 pushed to text_input at DMC/studentportalen 2025-12-12 12:21:30 +01:00
c03d577487 Merge package
stne3960 pushed to text_input at DMC/studentportalen 2025-12-12 12:19:36 +01:00
9904566a15 Unmerged paths