Andreas Svanberg ansv7779
  • Joined on 2021-07-26
1,243 contributions in the last 12 months
MayJunJulAugSepOctNovDecJanFebMarAprMonWedFri
Less
More
ansv7779 suggested changes for DMC/scipro#148 2025-04-22 13:47:10 +02:00
Supervisor Calendar Overview basic setup

Looks good but a few minor comments here and there.

ansv7779 deleted branch group-creation-ux from DMC/scipro 2025-04-22 11:56:46 +02:00
ansv7779 commented on pull request DMC/scipro#146 2025-04-22 11:37:04 +02:00
Split Project

This should be a java.time.Instant not java.util.Date.

ansv7779 commented on pull request DMC/scipro#146 2025-04-22 11:37:04 +02:00
Split Project

If possible try to get the current timestamp from an injected java.time.{Clock/InstantSource}. This makes testing easier since it is then possible to manipulate time (the infrastructure is already in place). Hopefully in the future this time manipulation is available during test data creation as well and maybe even test servers.

ansv7779 commented on pull request DMC/scipro#146 2025-04-22 11:37:04 +02:00
Split Project

Integration tests have access to time manipulation via injecting an instance of MutableFixedClock. This should allow you to set a specific date in either autumn or spring to get better assertions. Use Year.now(clock) to get the correct year for the fixed date that's been set.

ansv7779 commented on pull request DMC/scipro#146 2025-04-22 11:37:04 +02:00
Split Project

Use assertEquals instead of assertTrue. (This goes for every test).

ansv7779 commented on pull request DMC/scipro#146 2025-04-22 11:37:04 +02:00
Split Project

Integration tests have access to time manipulation via injecting an instance of MutableFixedClock. This should allow you to set a specific date in either autumn or spring to get better assertions. Use Year.now(clock) to get the correct year for the fixed date that's been set.

ansv7779 commented on pull request DMC/scipro#146 2025-04-22 11:37:04 +02:00
Split Project

For the future it might be a good idea to add an overload to reduce the overall diff. It is also confusing to read method calls with many null parameters.

ansv7779 commented on pull request DMC/scipro#146 2025-04-22 11:37:04 +02:00
Split Project

Replace with ldModel.map(status -> getStatusMessage(status)) to not get stale information when refreshing the page.

ansv7779 commented on pull request DMC/scipro#146 2025-04-22 11:37:04 +02:00
Split Project

Should use item.getModel().map(project -> ...) again to prevent possibility of stale data.

ansv7779 commented on pull request DMC/scipro#146 2025-04-22 11:37:04 +02:00
Split Project

This should be a java.time.Instant not java.util.Date.

ansv7779 suggested changes for DMC/scipro#146 2025-04-22 11:37:04 +02:00
Split Project

Overall I'm very impressed.

ansv7779 created branch user-consent in DMC/oauth2-authorization-server 2025-04-22 00:37:06 +02:00
ansv7779 pushed to user-consent at DMC/oauth2-authorization-server 2025-04-22 00:37:06 +02:00
0c55c25abf Add consent page (GUI)
c8f28d8283 Add consent page
1b08cdaf44 Test for authorization code flow with consent
ea5c3a1c00 Support for configuring end user consent requirement for clients
Compare 4 commits »
ansv7779 pushed to main at DMC/oauth2-authorization-server 2025-04-15 14:51:25 +02:00
8307bc4906 Verify public clients are not issued refresh tokens
3822f1229c Change the OAuth 2 / OIDC endpoint URLs.
09f2fe9430 Change the default JTE templates to be pre-compiled and switch to development mode only in the "dev" profile.
Compare 3 commits »
ansv7779 opened issue DMC/scipro#152 2025-04-14 16:07:08 +02:00
Final seminar participation removed
ansv7779 created branch basic-scaffolding-frontend-i18n-alt in DMC/studentportalen 2025-04-14 12:55:15 +02:00
ansv7779 pushed to basic-scaffolding-frontend-i18n-alt at DMC/studentportalen 2025-04-14 12:55:15 +02:00
ad515c5be9 Suppress eslint explicit any warnings required for the advanced type trickery to work.
c1647ab498 Basic i18n support
Compare 2 commits »
ansv7779 deleted branch x-forwarded-headers from DMC/oauth2-authorization-server 2025-04-10 10:31:23 +02:00