Tom Zhao tozh4728
  • Joined on 2024-05-16
tozh4728 pushed to 67-supervisor-target-non-blocking at DMC/scipro 2025-02-13 15:28:21 +01:00
46173d5da3 67: Merge from develop
b9f7dd5a49 Update supervisor's idea table immediately upon scheduling a first meeting (#105)
Compare 2 commits »
tozh4728 opened issue DMC/scipro#109 2025-02-13 12:56:46 +01:00
DataInitializer needs a refactorization
tozh4728 commented on pull request DMC/scipro#98 2025-02-13 09:49:24 +01:00
Grading Boundaries Wrong in Supervisor View

GradingReportService.getTemplate returns GradingReortTemplate, which contains a Collection of GradeLimit. However, the current data model of GradeLimit has no upper limit of a grade.…

tozh4728 commented on pull request DMC/scipro#96 2025-02-13 09:30:58 +01:00
Assign supervisor to student ideas no matter if target (goal) is reached

Fine point, the unnecessary null check has been removed.

The rationale for null check is that ideaService.countMatched returning Long. It would be better that a @NotNull annotation is applied…

tozh4728 pushed to 67-supervisor-target-non-blocking at DMC/scipro 2025-02-13 09:26:26 +01:00
aa801d0ae5 67: Remove unnessary null check
tozh4728 pushed to 67-supervisor-target-non-blocking at DMC/scipro 2025-02-12 13:35:29 +01:00
1b692f87fb 67: merge from develop
08e1b785ca Fix Docker build due to missing json-smart version (#107)
304d0431c1 Deadline visible in "Rough draft approval" page (#106)
219c312441 Fix localizer warning on the finishing up tab for each author (#101)
cbbd98b597 Upgrade Wicket version (#102)
Compare 6 commits »
tozh4728 deleted branch fix-dockerfile-json-smart from DMC/scipro 2025-02-12 13:28:17 +01:00
tozh4728 pushed to develop at DMC/scipro 2025-02-12 13:28:15 +01:00
08e1b785ca Fix Docker build due to missing json-smart version (#107)
tozh4728 merged pull request DMC/scipro#107 2025-02-12 13:28:14 +01:00
Fix Docker build due to missing json-smart version
tozh4728 pushed to 67-supervisor-target-non-blocking at DMC/scipro 2025-02-12 10:06:53 +01:00
32c066a1c5 67: Create student idea to test setting supervisor target
tozh4728 pushed to 67-supervisor-target-non-blocking at DMC/scipro 2025-02-10 14:50:43 +01:00
37b4e76ad2 67: Add languages to supervisors and add new student for submitting student idea.
tozh4728 pushed to 67-supervisor-target-non-blocking at DMC/scipro 2025-02-10 13:34:51 +01:00
f5c88c7b8e 67: Enable JPA save for employee.
tozh4728 pushed to 67-supervisor-target-non-blocking at DMC/scipro 2025-02-10 12:30:13 +01:00
6f82d5fdc4 67: Employee needs to set up as active supervisor.